Repository navigation
Stop packing the benchmark charts moved to the docs - #1314
Merged
Merged
Conversation
The README links them by URL since #1302, and packing them from their old location failed with NU5019.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1302 moved the benchmark charts to
docs/_content/fluid/assets/benchmarks,dotnet packfails withNU5019: File not found: 'Assets/benchmark-parse.png'. Every Build run on main since then failed in its Pack step, and tagging a release would fail the same way.The README links the charts by absolute URL now, so the package doesn't need them: this removes the three items from
Fluid/Fluid.csproj.Tested locally:
dotnet pack -c Releasecreates all the packages again.