Repository navigation
(ignore) just having fun miso ramen - #8636
siddharthkp wants to merge 7 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🦋 Changeset detectedLatest commit: a67085e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
🤖 Lint issues have been automatically fixed and committed to this PR. |
|
🤖 Lint issues have been automatically fixed and committed to this PR. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🤖 Lint issues have been automatically fixed and committed to this PR. |
|
🤖 Lint issues have been automatically fixed and committed to this PR. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🤖 Lint issues have been automatically fixed and committed to this PR. |
|
🤖 Lint issues have been automatically fixed and committed to this PR. |
No linked issue.
Adds one standalone Examples / Noodles page / Default story with the fixed Noodles theme.
This PR is independently based on
main(f733dcb2b), not stacked on the default-Primer story PR or any appearance-playground PR. It includes the same standalone workspace and fictional fixtures, a page-scoped theme, and only the component changes required for its typography: six CSS declaration replacements across ActionList and Button, exposing five optional hooks.There are no other new stories, configuration changes, appearance-playground providers, token engines, theme catalogs, extension files, appearance controls, Density controls, or Seriousness controls. Portal uses its existing public registration/context APIs and is not modified.
The story is render-only, without a Storybook
playfunction orstorybook/testimports. The page's real interactions remain available.Changelog
New
One standalone, interactive Noodles-inspired workspace with original fictional fixtures and a fixed, page-scoped theme. Navigation, project subpages, report switching, page creation/renaming/duplication, comments, attachment-name demos, reading width, focus mode, Markdown preview, and reset run locally without credentials, remote writes, or persistence.
Five optional component typography hooks, each falling back to the exact existing value:
--ActionList--label-fontSize-medium--text-body-size-medium--ActionList--label-fontWeight-selected--base-text-weight-semibold--ActionList--label-fgColor--fgColor-default--Button--fontSize-medium--text-body-size-medium--Button--fontWeight--base-text-weight-mediumChanged
PageLayout.Sidebar,PageLayout.Content, andPageLayout.Panefor navigation, document, and comments. The native sidebar resizes by dragging or keyboard from 240px to 480px, retains its width through hiding and focus mode for the current page session, and resets to 312px on double-click or reload. Story-local height and responsive rules preserve independent scrolling and narrow-screen stacking. No PageLayout component-source changes or additional styling hooks are required.Removed
Storybook interaction tests and their test-only imports were removed. The page's real interactions, layout and styling remain unchanged.
Rollout strategy
New styling hooks are opt-in and retain existing semantic-token fallbacks. The theme is confined to the story, not applied globally.
Testing & Reviewing
Latest verification
node /Users/siddharth/.copilot/session-state/ffb7aa4f-c550-485f-b591-35469fa88108/files/verify-noodles-render-only.mjs— passed. Session-only browser smoke check confirms that neither standalone story has aplayfunction orstorybook/testimport, both load without automatic demo mutations, and manual resizing, page creation, comments and reset still work without JavaScript errors.Earlier verification, before removing the Storybook interaction tests
NOODLES_PORT=6008 node /Users/siddharth/.copilot/session-state/ffb7aa4f-c550-485f-b591-35469fa88108/files/verify-noodles-pagelayout.mjs— passed. Session-only Playwright harness, not included in the PR: real pointer dragging, keyboard resizing, 240/480px bounds, double-click reset, width retention through sidebar toggles and focus mode, pinned header/footer during document scrolling, navigation scrolling, wide mode, desktop/stacked comments, and 320/390/767/768/1000px layouts. The story's interaction play also passed, including its new keyboard-resize assertions. No horizontal or vertical page overflow or JavaScript errors were observed.STORYBOOK=true npm run storybook --workspace @primer/react -- dev --port 6008 --no-open --ci— running successfully;/index.jsonreturns HTTP 200 and discovers exactly one new Noodles story./?path=/story/examples-noodles-page--default. The story's interaction assertions passed in Chrome, including muted 13px navigation labels, 400-weight selected labels on collapsed parents, and 13px/400-weight dark primary buttons.node ../verify-noodles-prs.mjs— passed. This is a local, session-only Playwright harness, intentionally not included in the PR. It checked the story's final interaction state, navigation, report switching, rename/duplicate, attachments, reading width, focus mode, themed menu/dialog portals, and layouts at 1440 × 1100 and 390 × 844, with no horizontal overflow or JavaScript errors.node ../verify-noodles-prototype-styles.mjs— passed against both the standalone themed story and the live Noodles-theme preview. Verified the reference's measured 24 × 18px two-digit counters, 28px menu rows, 4px menu padding, white popup with 12px corners, 109px footer, 28px account row, 32px New page control, and 16px bottom inset. Keyboard menu navigation, focus restoration, New page activation, account/settings actions, and the existing narrow-screen behavior also passed. This focused browser harness is session-only and not included in the PR.git diff --cached --check— passed. Changed files were formatted using the existing Prettier.