Repository navigation
(ignore) just having fun ramen - #8637
siddharthkp wants to merge 5 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 8224c67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
🤖 Lint issues have been automatically fixed and committed to this PR. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🤖 Lint issues have been automatically fixed and committed to this PR. |
|
🤖 Lint issues have been automatically fixed and committed to this PR. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🤖 Lint issues have been automatically fixed and committed to this PR. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🤖 Lint issues have been automatically fixed and committed to this PR. |
No linked issue.
Adds two standalone stories under Examples / Noodles page:
examples-noodles-page--defaultURL.examples-noodles-page--noodles-noodles, including its counters, menus, footer and New page styling.This PR is independently based on
main(f733dcb2b), not stacked on an appearance-playground PR. Both versions share fictional fixtures but retain their distinct presentation. There are no configuration changes, extension files, appearance controls, Density controls, Seriousness controls or other new stories.The only component-source changes are the same five optional ActionList/Button styling hooks used by #8636. Their fallback values are unchanged, preserving default Primer styling. The Noodles theme defines those values only inside its own scope; its registered portal container carries the same theme into menus and dialogs.
The Primer noodles stylesheet retains the CSS simplification: 430 to 219 lines (49% fewer) and 201 to 88 declarations (56% fewer), across 41 rules instead of 70.
Stackowns row/content spacing,Headingowns typography, andTruncatehandles breadcrumb titles. No theme variables are overridden in this version. The themed version keeps its existing dedicated stylesheet from #8636; it does not replace or expand the reduced Primer stylesheet.Changelog
New
playfunctions orstorybook/testimports.Changed
PageLayout.Sidebar,PageLayout.Content, andPageLayout.Panefor navigation, document, and comments. The native sidebar resizes by dragging or keyboard from 240px to 480px, remembers its width through hiding and focus mode within the current page session, and resets to 312px on double-click or reload.Stackand Heading variants, uses ordinary book/person icons instead of custom artwork, and keeps switcher/cover/Create as separate actions. Its mobile header controls wrap instead of overlapping.Removed
Rollout strategy
A minor changeset is included for the five optional component styling hooks. Consumers do not need to adopt them; default appearance and existing APIs remain unchanged.
Testing & Reviewing
Latest verification
node /Users/siddharth/.copilot/session-state/ffb7aa4f-c550-485f-b591-35469fa88108/files/verify-noodles-combined.mjs— passed. Both story IDs and labels are present; the themed styles match (ignore) just having fun miso ramen #8636; default Button/ActionList/NavList appearance remains unchanged. Repeated live Storybook switching, scoped menu/dialog portals, independent page creation and absence of interaction tests also pass without JavaScript errors.NOODLES_PORT=6007 node /Users/siddharth/.copilot/session-state/ffb7aa4f-c550-485f-b591-35469fa88108/files/verify-noodles-pagelayout.mjsandNOODLES_PORT=6007 NOODLES_STORY=noodles-noodles node /Users/siddharth/.copilot/session-state/ffb7aa4f-c550-485f-b591-35469fa88108/files/verify-noodles-pagelayout.mjs— both passed. Real pointer dragging, keyboard resizing, 240/480px bounds, double-click reset, width retention, pinned header/footer, independent scrolling, focus mode, wide mode, comments and 320/390/767/768/1000px layouts remain working without page overflow.node /Users/siddharth/.copilot/session-state/ffb7aa4f-c550-485f-b591-35469fa88108/files/verify-noodles-reduced-css.mjs— passed. The Primer stylesheet remains 219 lines/88 declarations with no unused/missing classes, inline styles or theme hooks. Native typography, separate switcher/cover/Create actions, menus, Markdown and long-title layouts at 1440/768/390/320px also pass. All browser helpers are session-only and are not included in the PR.npx --no-install prettier --write packages/react/src/stories/NoodlesPage.stories.tsx packages/react/src/stories/NoodlesPage.themed.tsx packages/react/src/stories/NoodlesPage.themed.module.css packages/react/src/ActionList/ActionList.module.css packages/react/src/Button/ButtonBase.module.css .changeset/noodles-component-typography.md— passed;git diff --check— passed.Storybook remains running at http://localhost:6007: