Repository navigation
Conversation
…157-open # Conflicts: # packages/cli/src/server.ts # packages/cli/tests/cli.test.mjs
JustKira
marked this pull request as draft
November 20, 2026 14:08
Contributor
Author
|
Parked. |
Contributor
Author
|
Closing without merging. The plugin shape, the server engine and sign-in are being decided again (Linear TKM-194 and TKM-195), and this work sits on top of them. Nothing is lost: the head commit is a8b60ab, and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linear: TKM-157. Stacked on #253; base:
feat/tkm-167-cli.On the local server, ACP compares the real paths of explicit folders and validates the configured folder before a thread is written. An agent's implicit home folder is excluded. If there is no agent, the thread remembers a starter folder until the picker saves a folder in the agent settings. The CLI uses the base's authenticated discovery and checks server identity before opening the socket. Named server selection still needs a later storage change; use
--serverorTOKAMAK_SERVERwithTOKAMAK_TOKEN.The window defers open requests during Add a server. Requests expire after five minutes and are deleted on acknowledgement; a short-lived receipt lets the CLI distinguish acknowledgement from replacement. Two windows signed in as the same person may both switch. There is no claim mechanism.
The SDK has no server-only function modifier for an action's nested mutation.
chat/open:recordnow accepts only an existing thread ID and queues the request for the authenticated user. It cannot take agent settings. The action prepares settings through the same provider configuration used by the picker, checks the resulting folder, and creates the thread through the existing insert mutation.Success JSON:
ok,threadId,created,folder,server,agent,folderRecorded,shown, andwindowConnected.windowConnectedreflects whether the CLI received an acknowledgement before its deadline.Evidence
link/..and a trailing-space folder, duplicates through the picker, navigation out of the connect form, and a local folder path being sent to a shared server.proto run bun -- test packages/cli/testsproto run bun -- run --cwd plugins/chat testcargo test -p server --no-fail-fast -- --test-threads=2proto run bun -- run e2e:browserbash .ci/check.sh lintbash .ci/check.sh tsMerge Danger
Door: Two-way. This PR adds request and receipt tables and an optional starter folder on threads.
Blast Radius: CLI and Chat.