Repository navigation
Give the provider inference test room to finish - #261
Merged
Merged
Conversation
It type checks several fixture plugins and took longer than the 5 second default on GitHub's runners and on a busy machine, so it failed by timeout while its assertions were fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One test in
packages/build/tests/descriptor.test.tstype checks several fixture plugins. It ran out of the test runner's 5 second default on GitHub's runners, so the TypeScript check failed on six open pull requests with no assertion failing. It now has 60 seconds.Evidence
Before: the TypeScript job on #248, #250, #251, #253, #254 and #258 ends with
provider inference checks public SDK reference kinds, arguments and results … this test timed out after 5000ms. The same test timed out locally whenever the machine was busy and passed alone in about 6 seconds.After: this pull request's own TypeScript check.
Merge danger
Two-way door: one timeout value on one test.