Repository navigation
Conversation
…o t3/stack-251 # Conflicts: # packages/runtime/PLUGINS.md # packages/server/src/plugins/catalog.rs # packages/server/src/plugins/loading.rs # packages/server/src/service/plugin_control.rs
Protect active dependents during skip propagation, report verification errors for known skipped builds, and derive catalog order from active plugins. Notify windows when the catalog revision changes.
JustKira
marked this pull request as draft
November 20, 2026 14:08
Contributor
Author
|
Closing without merging. The plugin shape, the server engine and sign-in are being decided again (Linear TKM-194 and TKM-195), and this work sits on top of them. Nothing is lost: the head commit is a3978ea, and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #250, which is stacked on #249.
Summary
An ACP action can finish while another plugin reloads. Reload compares plugin build ids and keeps unchanged workers and asset URLs. The window remounts changed views and their actual importers.
A retired action drops its wait on an unchanged worker without stopping it. Surviving actions resolve new calls and provider lookups against the published catalog. A window load that encounters a retired asset keeps its import edges so the next catalog can remount the importer.
Linear: TKM-162
Evidence
cargo test -p server --no-fail-fast -- --test-threads=2cargo test -p tokamak-appbash .ci/check.sh rustbash .ci/check.sh tsbash .ci/check.sh lintproto run bun -- e2e/run.tsproto run bun -- run e2e:browserproto run bun -- packages/build/tests/browser-assets.mjsStack interaction tests
In
packages/server/tests/reload.rs:changed_worker_swaps_while_skipped_index_is_retried— publishes the changed build, reports the new duplicate found on retry, and lets the unchanged worker finish its action.repaired_index_restores_only_skipped_plugin_and_required_dependent— restores both builds after a row repair with no rebuild; unrelated worker PIDs stay the same.failed_backfill_or_readiness_keeps_live_builds_and_indexes— either failure leaves the old catalog, build ids, worker PIDs and indexes in place.index_only_build_changes_revision_and_restarts_only_its_worker— the manifest hashes the backend bundle containing the schema, so an index edit changes the build id even when the worker code and version are unchanged.no_op_reload_preserves_running_actions_and_worker_pids— proves both actions finish on the same worker PIDs and no change event is emitted.Reload regression tests
Each test failed before its fix and passed afterward.
active_dependent_keeps_old_build_when_required_plugin_is_skipped— a new required dependency cannot evict an active plugin; the error names both plugins and the running action and workers survive.invalid_artifact_is_isolated_only_for_an_identified_skipped_plugin— a hash mismatch in a known skipped build is reported while another build reloads. Active corruption and invalid manifest identity still refuse the reload.skipped_only_edit_preserves_active_catalog_and_provider_order— changing a skipped build leaves the active order and revision stable. An active build change publishes the new revision.Known limits
and checks that the bundle imports and answers. It catches syntax errors,
missing imports, and code that throws during import. A worker can still fail
on its first real call if its import sees different files or settings in its
real working folder.
so that code runs without a sandbox. Writes to files or calls to outside
services during import can happen even if the reload is refused. Keep side
effects out of import time.
Merge Danger
Door: Two-way. No storage migration.
Blast Radius: Reloads. Existing sessions stay connected; asset addresses from before the upgrade may need a fresh catalog.