Repository navigation
feat(api): expose logical document deletion through Service API - #44970
Merged
Merged
Conversation
FFXN
requested review from
QuantumGhost,
crazywoola and
laipz8200
as code owners
October 28, 2026 10:54
Contributor
Pyrefly Type Coverage
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44970 +/- ##
=======================================
Coverage 89.54% 89.54%
=======================================
Files 6010 6010
Lines 377018 377028 +10
Branches 76333 76335 +2
=======================================
+ Hits 337597 337608 +11
+ Misses 33424 33423 -1
Partials 5997 5997
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hyoban
previously approved these changes
Oct 28, 2026
hyoban
approved these changes
Oct 28, 2026
hyoban
pushed a commit
that referenced
this pull request
Oct 29, 2026
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> (cherry picked from commit 4bd3120)
hyoban
pushed a commit
that referenced
this pull request
Oct 29, 2026
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> (cherry picked from commit 4bd3120)
hyoban
pushed a commit
that referenced
this pull request
Oct 29, 2026
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> (cherry picked from commit 4bd3120)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE /v1/knowledge-fs/spaces/{control_space_id}/logical-documents/{document_id}. The operation deletes the logical document with its historical revisions through the existing asynchronous deletion job.expectedRevisionfrom the logical document'srowVersionand anIdempotency-Key; return the public deletion-job status URL.Branch scope
This branch was created from
mainand contains only the Service API change. Opening the PR directly fromdeploy/konwledgewould include history already merged in #44165.Verification
ruff format --checkandruff checkon changed Python filestsrs --noEmitfor@dify/contractsgenerate_knowledge_fs_contract.py --check