Repository navigation
Conversation
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> (cherry picked from commit 4bd3120)
hyoban
requested review from
QuantumGhost,
crazywoola and
laipz8200
as code owners
October 29, 2026 02:32
github-actions
Bot
added
size:L
Contributor
Pyrefly Type Coverage
|
Member
Author
|
Merged into #45016. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of 4bd3120 (#44970) from
mainintohotfix/1.18.0-fix.2, created withgit cherry-pick -x.Conflict resolution:
packages/contracts/generated/api/service/errors.gen.tsdoes not exist on the hotfix branch, so it was dropped. I then rangen-api-contracton the hotfix branch and confirmed that the regenerated contracts exactly match the pickedorpc.gen.ts/types.gen.ts/zod.gen.ts, with noerrors.gen.tsfor service. Git matched the main testtest_resources.pyto the hotfix test filetest_knowledge_fs_service_contracts.pyas a rename, so the new test case was added there.Verification:
pytest tests/unit_tests/controllers/test_knowledge_fs_service_contracts.py: 44 passedknowledge-fs-logical-document-delete-contract.smoke.test.ts: 2 passedruff check/ruff format --checkon changed files: clean.github/scripts/check-hotfix-cherry-picks.shrun locally: provenance verified