Repository navigation
feat(layout): write line caches for paragraphs whose runs differ in face - #496
Merged
Merged
Conversation
3 tasks done
airmang
commented
Oct 16, 2026
airmang
left a comment
Owner
Author
There was a problem hiding this comment.
9de71f9099360120d7922798b68b6dfcd7c89b84에서 광고된 선행 브랜치 대비 diff와 서로 다른 글꼴·장평·자간의 글자별 폭/줄 높이 계산과 글리프 확인 경로를 검토했습니다. 별도 체크아웃의 줄 캐시 회귀 테스트 19개가 통과했고, 정확한 head의 모든 CI 검사 및 Python 3.12 로그(6866 passed, 18 skipped, 1 xfailed; coverage 기준, Ruff·mypy·Pyright·공개 게이트 통과)를 확인했습니다. 이 PR 고유 변경에서 추가로 재현한 결함은 없습니다. 다만 이 브랜치는 미병합 #491에 연쇄 의존하며, 그 PR의 캐시 작성 후 문단 위치 변경 결함이 여전히 재현되고 리뷰 스레드도 미해결입니다. 선행 #495에서도 다중 컨트롤 textpos 계산 결함이 확인됐습니다. 선행 문제가 수정·병합된 뒤 최신 base/head와 통합 결과를 재검증할 때까지 보류합니다.
airmang
force-pushed
the
feat/layout-line-caches-mixed-looks
branch
from
October 17, 2026 11:38
9de71f9 to
d7f1639
Compare
airmang
force-pushed
the
feat/layout-line-caches-section-controls
branch
2 times, most recently
from
October 17, 2026 11:39
a5f4a30 to
c7742f9
Compare
write_line_caches now also writes the cache of a paragraph whose runs differ in face, 장평 or 자간: each character breaks the lines at its own run's advance, as the page estimate lays such a paragraph out and as Hancom Office does. Its line breaks count as sure only when every character's advance comes from a glyph table for its own run's face. A tab in such a paragraph still leaves it for Hancom. A Hancom-saved fixture holds paragraphs of runs in several faces. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
airmang
force-pushed
the
feat/layout-line-caches-mixed-looks
branch
from
October 17, 2026 11:40
d7f1639 to
b4197c4
Compare
airmang
changed the base branch from
feat/layout-line-caches-section-controls
to
main
October 17, 2026 11:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #495.
Summary
write_line_cachesnow also writes the cache of a paragraph whose runs differ in face, 장평 or 자간.Test plan
🤖 Generated with Claude Code