Repository navigation
feat(layout): write the tab widths of paragraphs whose runs differ in face - #497
Merged
Merged
Conversation
airmang
commented
Oct 16, 2026
airmang
left a comment
Owner
Author
There was a problem hiding this comment.
748bf5846e06badb59b00db4bcf30c22564d949b에서 광고된 선행 브랜치 대비 diff와 혼합 글꼴에서 탭 앞뒤의 실제 run별 폭과 강제 줄 바꿈 뒤 탭 위치 계산를 검토했습니다. 별도 체크아웃의 줄 캐시 회귀 테스트 21개가 통과했고, 정확한 head의 모든 CI 검사 및 Python 3.12 로그(6868 passed, 18 skipped, 1 xfailed; coverage 기준, Ruff·mypy·Pyright·공개 게이트 통과)를 확인했습니다. 이 PR 고유 변경에서 추가로 재현한 결함은 없습니다. 다만 이 브랜치는 미병합 #491에 연쇄 의존하며, 그 PR의 캐시 작성 후 문단 위치 변경 결함이 여전히 재현되고 리뷰 스레드도 미해결입니다. 선행 #495에서도 다중 컨트롤 textpos 계산 결함이 확인됐습니다. 선행 문제가 수정·병합된 뒤 최신 base/head와 통합 결과를 재검증할 때까지 보류합니다.
2 tasks done
airmang
force-pushed
the
feat/layout-line-caches-mixed-looks
branch
from
October 17, 2026 11:38
9de71f9 to
d7f1639
Compare
airmang
force-pushed
the
feat/layout-line-caches-mixed-tabs
branch
from
October 17, 2026 11:38
748bf58 to
4d42d66
Compare
airmang
force-pushed
the
feat/layout-line-caches-mixed-looks
branch
from
October 17, 2026 11:40
d7f1639 to
b4197c4
Compare
… face A paragraph whose runs differ in face, 장평 or 자간 now keeps its tabs when write_line_caches writes its cache: the text before a tab takes each character's own run's advance, as the line breaking does, and the tab gets the width to the next default stop. A tab among characters of several sizes still leaves the paragraph for Hancom. A Hancom-saved fixture holds tabs among runs of several faces. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
airmang
force-pushed
the
feat/layout-line-caches-mixed-tabs
branch
from
October 17, 2026 11:40
4d42d66 to
7b3596c
Compare
airmang
changed the base branch from
feat/layout-line-caches-mixed-looks
to
main
October 17, 2026 11:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #496.
Summary
write_line_cacheswrites its cache.Test plan
🤖 Generated with Claude Code