Repository navigation
Conversation
Refs #987 Signed-off-by: tfm4 <310161029+tfm4@users.noreply.github.com>
6 of 8 tasks
tfm4
marked this pull request as ready for review
November 16, 2026 15:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The phase-catalog guard's self-test helpers leave the catalog input and fixture read/write files without explicit closure. Use context managers at the three reported sites so files close before subsequent validation reads them, preserving catalog entries, table contents, and refusal behavior.
Tracking issue: #987. Addresses code-scanning alerts 333, 334, and 335.
Block-completion review (ADR 1015)
Test plan
python3 ops/ci/check-phase-catalog.py --self-test— the unedited copy passes; a hand-edited table, missing required field, and nonexistent read path are refused; all 71 phases and generated tables match.python3 ops/ci/check-phase-catalog.py— passes on the current repository.9ba6fadawith 10 unclosed-file warnings from the three reported sites, and passes on this branch with zero.bash ops/ci/check-no-identity-spillage.sh ops/ci/check-phase-catalog.py— passes.bash ops/ci/check-no-live-secret.sh ops/ci/check-phase-catalog.py— passes with live values loaded.git diff --checkand local signature verification — pass.Both hosted Python CodeQL analyses passed. The broader Python/Ansible job was cancelled after about 30 minutes; a targeted rerun has been requested. Full CI validation remains pending. No scanner alerts have been manually dismissed; closure on main awaits merge and a successful main-branch scan.
Cross-repo coordination
Documentation
Checklist
git commit <path>form for the single changed file.Security-sensitive?
Notes for reviewers
Keep tracking issue #987 open until its acceptance criteria, including merge and scanner-confirmed closure on main, are satisfied. This PR uses a non-closing issue reference so that merge alone does not claim that the alerts have been rescanned.