Skip to content

chore(ci): close phase catalog self-test files #987

Open

Description

@tfm4

Estimate (story points)

Not yet estimated.

As a...

A CI maintainer validating the phase catalog and generated documentation tables.

I want...

The phase-catalog guard's self-test helpers to close the catalog input and fixture read/write files explicitly.

So that...

The self-tests release file resources deterministically while preserving the validation rules and generated-table checks.

Context

Ordinary file-resource maintenance in ops/ci/check-phase-catalog.py, covering code-scanning alerts 333, 334, and 335. The three sites are in the self-test helpers that copy and edit temporary fixtures.

Acceptance criteria

  • Given the original self-tests, when file-resource warnings are captured, then the three reported file operations reproduce unclosed-file warnings.
  • Given the fix, when the same probe runs, then no unclosed-file warnings originate from the three sites.
  • Given an unedited fixture copy, when the guard runs, then it passes; a hand-edited table, missing required field, and nonexistent read path remain refused.
  • Given the current repository, when the guard runs normally, then its catalog and generated-table checks pass.
  • Given the PR, when hosted CI and Python CodeQL analyses run, then they pass.
  • Given maintainer approval, when the PR merges and main is successfully scanned, then alerts 333, 334, and 335 are recorded as fixed.

Out of scope

Changing the phase catalog, generated table contents, validation rules, release workflows, operational configuration, or other code-scanning findings.

Pre-flight

  • Existing issues were searched; no equivalent tracking issue was found.
  • This issue contains no CUI or PII.

Affected repository: USAREUR-AF/goatcore.

Implementation: #988. Local checks and both hosted Python CodeQL analyses pass. The broader Python/Ansible job was cancelled after about 30 minutes; a targeted rerun has been requested. Full CI validation remains pending.

Activity

  1. self-assigned this
    on Nov 16, 2026
  2. added
    choreMaintenance, CI, cleanup
    needs-triageNew; not yet labeled, prioritized and assigned
    area/releaseCI, images, releases, supply chain
    on Nov 16, 2026
  3. moved this to In Progress in GOAT Roadmapon Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area/releaseCI, images, releases, supply chainchoreMaintenance, CI, cleanupneeds-estimateNot yet sizedneeds-triageNew; not yet labeled, prioritized and assigned

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions