Repository navigation
fix(WebGPU): use filterable textures for 16-bit image scalars - #3748
Merged
Merged
Conversation
This was referenced Nov 7, 2026
PaulHax
marked this pull request as draft
November 7, 2026 19:03
2 of 3 tasks
PaulHax
marked this pull request as ready for review
November 7, 2026 19:11
PaulHax
force-pushed
the
webgpu-filterable-image-scalars
branch
from
November 7, 2026 19:13
0f91102 to
570572b
Compare
2 tasks done
PaulHax
force-pushed
the
webgpu-filterable-image-scalars
branch
from
November 9, 2026 14:59
570572b to
5850a49
Compare
PaulHax
force-pushed
the
webgpu-filterable-image-scalars
branch
from
November 11, 2026 13:20
5850a49 to
9f28e36
Compare
Collaborator
|
It would good if you can attach a before/after or a screenshot of the issue |
Collaborator
Author
Before the vtk.js viewprot is just white in Chrome with WebGPU rendering. After, it shows the volume. |
|
🎉 This PR is included in version 38.0.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
VolumeMapperLightAndShadow uses a linearly filtered texture for the head volume. On devices with
texture-formats-tier1, vtk.js selectsr16snormfor those scalars. WebGPU only permits an unfilterable float binding for that format. Example · Original format selection · WebGPU format tableThe console error in the example without this fix in WebGPU mode
Results
Signed and unsigned 16-bit image scalars can be sampled with a linear sampler. For values outside the exact integer range of half-float, the accuracy path can use four bytes per component when float32 filtering is available. Compact storage takes two bytes and can round values.
Changes
Use the existing float16/float32 selection for 16-bit image scalars on tier1 devices, including when updating an existing texture.
PR Checklist