Skip to content

fix(VolumeMapperLightAndShadow): improve opening view and widget styling - #3752

Merged
PaulHax merged 1 commit into
Kitware:masterfrom
PaulHax:volume-light-shadow-opening-view
Nov 9, 2026
Merged

PaulHax merged 1 commit into
Kitware:masterfrom
PaulHax:volume-light-shadow-opening-view

Conversation

@PaulHax

@PaulHax PaulHax commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Context

VolumeMapperLightAndShadow opens with a view from beneath the head. The volume controller's theme-class lookups also miss their CSS Module exports, leaving the logo and dropdowns without their intended styling.

Results

The head opens upright and closer to the camera. The stock volume controller uses its intended compact logo and theme colors. A renderer button switches between WebGL and WebGPU by reloading the example.

WebGPU rendering on devices with texture-formats-tier1 still requires #3748.

Changes

  • Reorient the camera and move it closer to the volume.
  • Align the shared volume controller's theme class names with its CSS Module exports.
  • Add the renderer switch, match the FPS monitor font to the controls, and stretch the render canvas to avoid overflow at fractional display scaling.
  • Update the example description.

PR Checklist

  • GitHub Actions CI passed: semantic-release commit messages, lint, and tests
  • Documentation and TypeScript definitions are updated to match these changes

@PaulHax
PaulHax force-pushed the volume-light-shadow-opening-view branch from 498d297 to 36c0364 Compare November 7, 2026 19:36

@finetjul finetjul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@finetjul finetjul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaulHax
PaulHax added this pull request to the merge queue Nov 9, 2026
Merged via the queue into Kitware:master with commit 3c78fbb Nov 9, 2026
4 checks passed
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 38.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions Bot added the released Automated label label Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Automated label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants