Skip to content

Exclude CLI poller from patch coverage accounting #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheWitness merged 1 commit into from
Nov 9, 2026
Merged

Exclude CLI poller from patch coverage accounting #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/bin/patch-coverage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,12 @@ function changed_lines($base_ref) {
// time, not exercisable in the isolated unit process, and asserted
// end-to-end by the lifecycle/wiring tests.
'includes/database.php',
// The poller is a CLI entry point with top-level argument handling,
// Cacti bootstrap, and process exits; it cannot be loaded in the isolated
// unit process. Pure collector behavior is exercised through
// mikrotik_test_load_function(), though eval prevents Clover from mapping
// those executed lines back to this source file.
'poller_mikrotik.php',
// Web UI entry points (chdir + include auth.php, top-level execution); not
// loadable in the isolated unit process. Their pure helpers are covered via
// mikrotik_test_load_function(); their render output is asserted by the UI.
Expand Down
Loading