Repository navigation
Exclude CLI poller from patch coverage accounting - #130
Merged
Merged
Conversation
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
fix/cli-poller-coverage-accounting
branch
from
November 9, 2026 03:36
4cef52f to
f3cb266
Compare
|
TheWitness
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The patch-coverage gate cannot associate eval-loaded unit-test function lines with poller_mikrotik.php. The poller is a CLI entry point with top-level bootstrap and process exits, so it cannot be safely loaded in the isolated unit process.
Add it to the existing explicit unmeasured-file allowlist with this limitation documented. The collector regression behavior remains exercised by the focused Pest tests.
Related: #126
Fixes #129