Repository navigation
Give the exact error text for a JSON Builder with no sequence number - #139
Merged
Merged
Conversation
Every implementation gives the same message when no Sequence Element has produced a sequence number, with JSON Bundler in place of JSON Builder in PHP. Where the error is wrapped, the error the caller reads carries the message.
Nothing is added to the message, such as a documentation link. A prefix that a language's error type writes in front of every error of that type is not part of the message.
jwrosewell
marked this pull request as ready for review
November 11, 2026 13:19
This was referenced Nov 11, 2026
Merged
Merged
Give the specification's JSON Builder error text with no sequence number
51Degrees/51degrees-node#74
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
James Rosewell's rule for the 11 November 2026 release is "The point of the release is consistency." The error a JSON Builder gives when no Sequence Element has produced a sequence number reads differently in every language that gives one.
rcMessages.resxlines 120 to 122)JsonBuilderElement.javalines 206 to 229)jsonbundler.jslines 73 and 74)Messages.phpline 53)jsonbundler.pylines 110 to 113)jsonbuilder.golines 109 to 111)What the specification said
json-builder.mdat 67ead698, lines 120 to 124:A SHOULD about what the error says left each language free to choose its own words, which is how six languages came to give six different messages.
What changed
json-builder.mdat the head of this draft, section "Sequence number", in the same form as the Errors table indata-updates.md.ConfigurationErrorwrites in front of its message stays (errors.golines 45 to 50). The second commit, 2285798, adds this item, because the first left open whether anything could follow the message.The rest of the section is unchanged, including the paragraph on
query.sequencetext from a query string.The language drafts that give this text
Checks
The repository has no pull request build. Both of its pull request checks passed on the head, 2285798:
What remains
Nothing in this draft. The language drafts above wait for this one, because each cites the text it states.