Repository navigation
Give the specification's JSON Builder error text with no sequence number - #100
Merged
Merged
Conversation
Every language gives the same text when no Sequence Element has produced a sequence number, as the JSON Builder page of the specification states.
This was referenced Nov 11, 2026
Merged
Merged
Give the specification's JSON Builder error text with no sequence number
51Degrees/51degrees-node#74
Merged
jwrosewell
marked this pull request as ready for review
November 11, 2026 13:52
This was referenced Nov 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
James Rosewell's rule for the 11 November 2026 release is "The point of the release is consistency." When no Sequence Element has produced a sequence number, the JSON Builder fails with an error, and each language that has the error gave it its own wording. Go said "the JSON Builder Element found no sequence number, so a Sequence Element needs to be placed before it in the Pipeline" (
pipeline/elements/jsonbuilder/jsonbuilder.golines 109 to 111 onrc).What the specification says
specifications#139, merged into rc as d72eb074, gives the exact text.
json-builder.mdat d72eb074, lines 120 to 142:What changed
Two commits, the test first (13639c6) and then the message (2787857). Nothing else changes.
pipeline/elements/jsonbuilder/jsonbuilder.golines 109 to 111,Processreturns a*core.ConfigurationErrorwhoseMessageis now the text. ItsError()puts the "pipeline configuration error: " prefix that everyConfigurationErrorgives in front of the message (pipeline/core/errors.golines 45 to 50), so the error the caller reads carries the text, after that prefix. Go usually writes error strings in lower case with no full stop, and this one keeps the specification's capitals and full stops because the text has to be the same in every language. The repository runs no linter that checks this.TestJSONBuilderSequenceNumberinpipeline/elements/jsonbuilder/sequence_test.go, the constant at lines 36 to 39 and the checks at lines 121 to 128 now asserts, in every case that must fail and whether the Pipeline returns the error or only records it, that theConfigurationError'sMessageequals the exact text and thatError()ends with it. Before, it checked only that "Sequence Element" appeared, which the old wording also passed.Tests and builds
Setting 'PullRequestSha'line in its job logs (4 of them) reads 2787857. macOS was left out of this draft's full build under the 9 November decision. The rc head is built with macOS before it merges into main.What remains
specifications#139, which states the text, has merged into rc as d72eb074. The same text goes into the other languages in 51degrees-dotnet#135, 51degrees-java#104, 51degrees-node#74, 51degrees-python#101, 51degrees-php#69 and 51degrees-rust#383. Nothing else is outstanding here.