Repository navigation
Conversation
kevwan
force-pushed
the
fix/dart-embedded-struct
branch
from
November 5, 2026 15:03
ac1a1c2 to
f3cfc1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4777
When an API type embeds another struct,
goctl api dartfails withcannot get property name of ""because the generator treats theanonymous embedded member as a named field.
This change expands embedded fields while preserving their tags and
converting their Dart types. It supports nested and pointer embeddings
in both data templates, and handles embedded path parameters.
Regression tests cover embedded structs, custom JSON tags, field
conflicts, and both API parsers.
Validation:
go test ./api/dartgen -count=1passed.go vet ./api/dartgenpassed.on Windows. These failures were also reproduced with unmodified source.