Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
status="error"Why
run_with_telemetry()already finishes and logs an error snapshot, but it re-raises before the existing metrics bridge call. As a result, failed search operations appear in the generic HTTP 500 metric but are absent from operation-level metrics.This was reproduced through
POST /api/v1/search/searchat0fcc1663811914484163993735dfbef2c3ca2080: the request emitted one generichttp.requestevent and zerotelemetry.summaryevents. The same probe after this change emits exactly one operation summary withoperation="search.search",status="error", andRuntimeError, while preserving the public 500 response.The investigation was prompted by Cognee issue #5991, which reports elevated production recall failures and the need for operation-level error telemetry. The implementation here is independent and limited to OpenViking's existing telemetry bridge contract.
Closes #6236.
Validation
pytest -q tests/metrics/integration/test_telemetry_bridge.py tests/telemetry/test_execution.py— 16 passedtelemetry.summaryevent withstatus="error"ruff checkon all changed filesruff format --checkon all changed filesgit diff --check