Repository navigation
Conversation
mount.veracrypt is a POSIX shell script since veracrypt#1895 and runs with BusyBox ash, so the OpenWrt recipe no longer needs bash: drop it from the package dependencies, the minimal SDK config, the feeds and runtime packages the build script prepares, the QEMU test's package list, and the README. Signed-off-by: Ville Takio <ville+git@takio.fi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mount.veracryptis a POSIX shell script since #1895 (it runs with BusyBoxash), but the OpenWrt recipe added by #1615 still declares+bashand its README says the helper has a Bash shebang. This dropsbashfrom the package dependencies, the minimal SDK config, the feeds and runtime packagesbuild_veracrypt_openwrt.shprepares, the QEMU test's package list, and the README.The POSIX helper runs on OpenWrt without bash: it is installed that way by the OpenWrt packages feed submission (openwrt/packages#30597) and tested with BusyBox
ashon an RT-AX53U (OpenWrt 25.12, mipsel). I did not run the full SDK + QEMU flow here.