Repository navigation
Conversation
A relative rootDir made TypeScript throw when the project tsconfig has composite: true.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
|
dlhck
marked this pull request as ready for review
November 14, 2026 08:06
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
analyzeProject()passes the relativerootDir: './src'to ts-morph. When the projecttsconfig.jsonhascomposite: true, TypeScript compares that relative path with an absolute path and throws:Projects that use
composite: true, for example with project references, are affected. Thevendure schema,vendure add,vendure migrateandvendure doctor(config check) commands callanalyzeProject(), so they fail in such a project. Projects withoutcomposite: trueare not affected.The fix is one line:
rootDir: path.resolve('./src').The new test,
shared-prompts.spec.ts, runsanalyzeProject()in a temporary project and asserts that the source file insrc/is loaded. One case uses a plain tsconfig. The other usescomposite: true, and it fails without the fix with the error above. The test removes the temporary directory afterwards.Breaking changes
No.
Checklist
📌 Always:
👍 Most of the time:
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.