Skip to content

Disable route popup during marker drag - #425

Merged
nilsnolde merged 4 commits into
valhalla:masterfrom
M393:marker-drag-on-route
Oct 1, 2026
Merged

nilsnolde merged 4 commits into
valhalla:masterfrom
M393:marker-drag-on-route

Conversation

@M393

@M393 M393 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

🛠️ Fixes Issue

Rendering of the route popup would reset the marker position mid-drag.
This happens when you drag the marker along an already rendered route.

👨‍💻 Changes proposed

Disable tour route popup during marker drag

M393 and others added 2 commits August 10, 2026 15:13
Rendering of the route popup would reset the marker position mid-drag.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
nilsnolde
nilsnolde previously approved these changes Sep 30, 2026
@nilsnolde
nilsnolde enabled auto-merge (squash) September 30, 2026 16:47
@nilsnolde

Copy link
Copy Markdown
Member

sorry for the late review @M393 . seems some test is failing

Matching by substring '3' returned the graph age button when it contained a 3.
auto-merge was automatically disabled October 1, 2026 12:45

Head branch was pushed to by a user without write access

@M393

M393 commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

It matched the graph age button by chance because it contained a 3 at the time that test was executed.

9 × locator resolved to <button data-state="closed" data-slot="tooltip-trigger" class="cursor-help underline decoration-dotted underline-offset-2">about 3 hours ago</button>

@nilsnolde
nilsnolde merged commit f849964 into valhalla:master Oct 1, 2026
2 of 3 checks passed
@M393
M393 deleted the marker-drag-on-route branch October 1, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants