Repository navigation
Schedule the update checks again after /usb reload - #240
Merged
Merged
Conversation
A reload cancels all of the plugin's tasks and starts new services with a new SkyUpdateChecker, but the checks were only scheduled once, in onEnable. After the first /usb reload no check ran until the next restart, and /usb version, which reads the new checker, never showed an available update or the manual-check hint. Turning plugin-updates.check on with a reload had no effect. The services now schedule the checks at every start, the reload's too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/usb reloadcancels the plugin's tasks and builds a new update checker, but the 4-hourly update check was scheduled only once, at startup. After the first reload no check ran until a restart:/usb versionnever showed an update or the manual-check hint, and turningplugin-updates.checkon with a reload did nothing.Services.startup()now schedules the check, so it runs after startup and after every reload, exactly once each time. The old call inuSkyBlock.onEnableis gone.ServicesTest. After a reload the check is scheduled again exactly once; with the check off no request goes out, and switching it on sends one. Both fail without the fix.