Repository navigation
Honour plugin-updates.check: false - #239
Merged
Merged
Conversation
The update check was scheduled every four hours and fetched the latest version regardless of the option. The scheduled task now reads the current config on each run and skips the request when the check is disabled, so /usb reload can switch it on or off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plugin-updates.check: falsedidn't stop the update check: the task inuSkyBlock.javaasked for the latest version every 4 hours regardless of the setting.The task now calls
checkForUpdatesIfEnabled(), which reads the current config on every run. Turning the option off with/usb reloadstops further requests, and turning it on starts them again.uSkyBlockTest. With the check off, no request is made; with it on, one is; a reload that turns it off stops further requests. All three fail without the guard.testImplementationline for httpclient5.