Repository navigation
fail on an unreadable or unparsable env file - #373
Merged
Merged
Conversation
envVars only logged a warning when the env file could not be parsed and the run went on without any of its vars, so a typo in env.yml ran the playbook with empty values. A parse error is now returned. A missing file is still skipped, and a file with no yaml document (empty or comments only) still counts as no vars.
envVars treated every os.Open error as a missing env file, so an env.yml that exists but cannot be read (permission denied) was skipped without a log line and the playbook ran with empty values. Only a file that does not exist is skipped now; any other open error is returned. TestEnvVars also checks that both error messages name the env file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
envVarsskipped the env file on any open error and only logged a warning when the file could not be parsed. A typo or a permission problem inenv.ymlran the playbook with empty values for every var from the file.now any parse error, and any open error other than a missing file, stops the run with a message naming the file. A missing env file is still skipped, and an empty or comments-only file still means no vars.