Skip to content

Fix exit code and manifest path - #134

Merged
ensko merged 4 commits into
typst-community:mainfrom
ensko:fix-exit-code-and-manifest-path
Oct 27, 2026
Merged

ensko merged 4 commits into
typst-community:mainfrom
ensko:fix-exit-code-and-manifest-path

Conversation

@ensko

@ensko ensko commented Oct 25, 2026

Copy link
Copy Markdown
Collaborator

This is a small functional change: it changes the command to exit with ExitCode::FAILURE if an error was reported, and fixes that init did not respect UTPM_CURRENT_DIR. Both are necessary to fully facilitate testing via #133: the exit code to test proper failures, the env var to properly isolate all commands.

@ensko
ensko force-pushed the fix-exit-code-and-manifest-path branch from 750f3d4 to 8f734ad Compare October 26, 2026 08:40

@Thumuss Thumuss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already did it in #132 but since it's to fix the other PR (#133) and I didn't test it yet, you can merge!

@Thumuss Thumuss mentioned this pull request Oct 26, 2026
8 of 14 tasks
ensko added 4 commits October 27, 2026 10:08
Both tests fail for now: utpm logs errors but always exits with 0.
Errors were logged, but the process always exited with 0, so scripts
and CI could not detect failures.
Fails for now: the manifest is written to the process working directory.
write_manifest always wrote to ./typst.toml, ignoring UTPM_CURRENT_DIR,
while init itself checked for an existing manifest in get_current_dir().
It now takes the manifest path explicitly.
@ensko
ensko force-pushed the fix-exit-code-and-manifest-path branch from 8f734ad to 6a7f27d Compare October 27, 2026 09:08
@ensko
ensko merged commit 9b9b025 into typst-community:main Oct 27, 2026
6 checks passed
@ensko
ensko deleted the fix-exit-code-and-manifest-path branch October 27, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants