Repository navigation
Keep the NIC loopback test off the NFS root and tolerate logind session races - #130
Merged
Merged
Conversation
Open sysfs attributes before taking the interface down and rewind their descriptors for each read. Restore MTU, flags and IPv6 through files opened before the test. Require cache-drop setup to succeed and enable a 65-second offline hold to expire default NFS directory attributes. Preserve frame, ordering, socket-drop and counter checks and result tokens. Validate setup failure and restoration with a shell test. Lint and the fast Python suite pass in the pinned image; the static cross build passes with warnings treated as errors.
Inspect each failed unit's Result before accepting degraded systemd. Limit the exception to numeric session scopes with resources results, require a complete successful listing, and log the tolerated scopes. Cover normal startup, session races, mixed and unrelated failures, and incomplete or conflicting query output in the Linux-stage tests. Lint and the fast Python suite pass in the pinned image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frost_nettest read its sysfs counters by absolute path while the NIC was down. On an NFS root, such a lookup can need the link the test has taken down, so the test blocked for good and the root never came back. The test now opens the interface's sysfs files while the link is up and reads them through those descriptors. The shell restores MTU, flags and IPv6 through files it opened before the test. The stage holds the link down for 65 seconds (
FROST_NETTEST_EXPIRE_NFS_CACHE=1), past NFS's default 60-second directory attribute lifetime, so a lookup left in that window would hang every run instead of occasionally.On a slow boot, a logind session scope can fail with result
resources("No PIDs left to attach to the scope's control group"), which leaves systemd degraded. The systemd check now accepts degraded only when every failed unit is asession-N.scopewithResult=resources, and logs the scopes it tolerated. Any other failed unit still fails the stage.The Linux-stage tests cover a running system, tolerated session races, mixed and unrelated failures, and incomplete query output. Lint and the fast tests pass.