Repository navigation
Fix/windows notification default sound - #1417
Conversation
The silent field and the rebinding are only read on Windows, so macOS and Linux reported unused_mut and dead_code. Also apply prettier to the two JS files.
|
@reg-chen Thanks for tracking this down and testing it on real Windows machines, merged. I pushed two small follow-ups to your branch before merging. The |
|
You're right, I overlooked the implications for macOS and Linux when implementing the Windows-specific fix. I should have considered cross-platform compatibility more carefully. Thank you for catching that, making the necessary adjustments, and adding the regression test. I really appreciate the thoughtful review and the quick merge! I'm glad I could contribute, and I've learned something from your improvements. |
2 participants
Tested with a Pake 3.17.5-based Windows MSI on multiple PCs. Native notifications were previously silent. After forwarding the silent option and explicitly selecting the Windows Default sound, native notification audio works correctly.