Repository navigation
Phase 6: guides, compliance fixes, credential checks, release prep - #6
Merged
Merged
Conversation
…se prep Add guides for getting started, migrating from twilio-ruby, migrating from Noticed's Twilio method, a compliance primer, and writing a provider, plus a test that every setting, constant, and generator they name exists. Compliance research changed defaults: HELP replies name a support contact (support_contact), the opt-out confirmation follows CTIA wording, keywords ignore internal spaces so "opt out" matches, and opt_out_all_scopes prepares for the FCC revoke-all provision. Fix the Noticed adapter reusing Noticed's own wait/queue/priority keys, which delayed a message twice; its job options are now sms_queue and sms_priority. Implement Smswire.verify_credentials! for Twilio, Telnyx, and Vonage. Settle open decisions 4 to 6 as implemented, list known limitations, and add RELEASING.md and a tag-triggered trusted-publishing workflow. The version is unchanged; publishing 1.0 is left to the maintainer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L5SuBiSMN4r9qr5CXbKkHV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Phase 6 of
docs/SPEC.md. Stacked on #5 (then #4 to #1). Merge in order. The version is unchanged and nothing is published; cutting 1.0 is left to the maintainer.What's included
docs/guides, linked from the README:twilio_messaging;Smswire.verify_credentials!. It makes one read-only authenticated call per provider: the Twilio account, the Telnyx balance, or the Vonage balance. It's useful for boot checks and health endpoints. It was in spec section 6.8 but no phase had built it.RELEASING.mdcovers one-time trusted-publisher setup, a pre-1.0 checklist, release steps, and recovery..github/workflows/release.ymlruns tests on av*tag, checks the tag matches the gem version, and publishes with trusted publishing.Changes from compliance research
Checking current FCC and CTIA guidance for the primer exposed gaps in the shipped defaults:
support_contactsetting is interpolated into the reply. Without one, the reply omits it and a warning is logged.opt_out_all_scopes. This setting makes STOP apply to every consent scope, ahead of the FCC revoke-all provision, which is delayed to January 31, 2027.Bug fixed
The Noticed adapter read
wait,queue, andpriorityfrom thedeliver_byblock, but Noticed uses those keys for its own job, soconfig.waitdelayed a message twice. Smswire's job options are nowsms_queueandsms_priority, and a test asserts the delay applies once.Spec
phonelibused when present;deliver_nowis allowed;Verification
🤖 Generated with Claude Code
https://claude.ai/code/session_01L5SuBiSMN4r9qr5CXbKkHV