[ariesdevil]

Summary

• Upgrade direct dependencies to the latest stable versions compatible with Rust 1.93.0, including tonic 0.14, prost 0.14, rand 0.10, clap 4, and reqwest 0.13.
• Migrate to tonic-prost and tonic-prost-build, regenerate protobuf bindings, and adapt code to API changes.
• Keep serial_test at 3.5.0 because 4.0.1 requires Rust 1.93.1.

Tests

• make check
• make unit-test - 139 passed
• TiKV/PD v8.5.5 integration tests - 55 transactional and 11 raw tests passed

Summary by CodeRabbit

• Chores
  • Updated supporting components and build tooling to newer versions.
  • Modernized internal handling of command-line options, random values, and transaction timestamps. These changes do not alter the app’s existing behavior or capabilities.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nrc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ariesdevil]

As the MSRV is 1.93.0, no need to be kept.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 3dc262aa-7916-45dc-9603-9d8cd88d00ae

📥 Commits

Reviewing files that changed from the base of the PR and between 1b883bf and 98d336f.

⛔ Files ignored due to path filters: 35

• src/generated/autoid.rs is excluded by !**/generated/**
• src/generated/backup.rs is excluded by !**/generated/**
• src/generated/cdcpb.rs is excluded by !**/generated/**
• src/generated/configpb.rs is excluded by !**/generated/**
• src/generated/coprocessor.rs is excluded by !**/generated/**
• src/generated/deadlock.rs is excluded by !**/generated/**
• src/generated/debugpb.rs is excluded by !**/generated/**
• src/generated/diagnosticspb.rs is excluded by !**/generated/**
• src/generated/disaggregated.rs is excluded by !**/generated/**
• src/generated/disk_usage.rs is excluded by !**/generated/**
• src/generated/encryptionpb.rs is excluded by !**/generated/**
• src/generated/enginepb.rs is excluded by !**/generated/**
• src/generated/eraftpb.rs is excluded by !**/generated/**
• src/generated/errorpb.rs is excluded by !**/generated/**
• src/generated/gcpb.rs is excluded by !**/generated/**
• src/generated/google.api.rs is excluded by !**/generated/**
• src/generated/import_kvpb.rs is excluded by !**/generated/**
• src/generated/import_sstpb.rs is excluded by !**/generated/**
• src/generated/keyspacepb.rs is excluded by !**/generated/**
• src/generated/kvrpcpb.rs is excluded by !**/generated/**
• src/generated/logbackup.rs is excluded by !**/generated/**
• src/generated/meta_storagepb.rs is excluded by !**/generated/**
• src/generated/metapb.rs is excluded by !**/generated/**
• src/generated/mpp.rs is excluded by !**/generated/**
• src/generated/pdpb.rs is excluded by !**/generated/**
• src/generated/raft_cmdpb.rs is excluded by !**/generated/**
• src/generated/raft_serverpb.rs is excluded by !**/generated/**
• src/generated/recover_data.rs is excluded by !**/generated/**
• src/generated/replication_modepb.rs is excluded by !**/generated/**
• src/generated/resource_manager.rs is excluded by !**/generated/**
• src/generated/resource_usage_agent.rs is excluded by !**/generated/**
• src/generated/schedulingpb.rs is excluded by !**/generated/**
• src/generated/tikvpb.rs is excluded by !**/generated/**
• src/generated/tracepb.rs is excluded by !**/generated/**
• src/generated/tsopb.rs is excluded by !**/generated/**

📒 Files selected for processing: 14

• Cargo.toml
• examples/common/mod.rs
• proto-build/Cargo.toml
• proto-build/src/main.rs
• src/backoff.rs
• src/request/mod.rs
• src/request/plan.rs
• src/request/shard.rs
• src/transaction/client.rs
• src/transaction/transaction.rs
• src/transaction/transaction/scanner.rs
• tests/common/mod.rs
• tests/failpoint_tests.rs
• tests/integration_tests.rs

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Walkthrough

The pull request updates dependency versions, migrates example argument parsing and protobuf generation APIs, and updates random-number API usage. It also removes explicit clones in request and transaction paths without changing their described behavior.

Changes: Dependency and API updates

Layer / File(s)	Summary
Dependencies, argument parsing, and protobuf generation Cargo.toml, examples/common/mod.rs, proto-build/Cargo.toml, proto-build/src/main.rs	Dependencies are updated, including tonic 0.14 with tls-ring and tonic-prost. Example arguments use clap’s builder API. Protobuf generation uses tonic-prost-build.
Random-number API migration src/backoff.rs, src/request/shard.rs, tests/common/mod.rs, tests/failpoint_tests.rs, tests/integration_tests.rs	Random sampling switches to rng, random, random_range, and sample. The described bounds, input sizes, and assertions remain unchanged.
Request planning and fixture copies src/request/mod.rs, src/request/plan.rs	Request planning copies peer, epoch, and timestamp values directly. Test fixtures move leader values into peer collections.
Transaction timestamp value usage src/transaction/client.rs, src/transaction/transaction.rs, src/transaction/transaction/scanner.rs	Transaction, scanner, and lock-resolution paths pass or store timestamp values without explicit clones. The described transaction behavior and scan flow remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Other

Suggested reviewers: eduralph

Merge Risk: ⚪ Minimal · up to 98d33

The dependency and API updates preserve the described request and transaction behavior, and the locked versions support Rust 1.93.0. No concrete build or user-impacting blocker remains.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 53.85% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 39 functions across 12 files. (2 skipped:…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly identifies the main change: upgrading dependencies to match the project's MSRV. It is concise and relevant, although the wording is slightly informal.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 53.85% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 39 functions across 12 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

• Fix all pre-merge checks with AI

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 Clippy (1.98.1)

Clippy execution failed

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}