[dani-zilla]

Contribution Summary

Closes #11913

feature-flag: push_enabled_on_inbox_by_default

Description

Enables the default-on push settings for all builds and updates the tests to reflect that change

Testing

This has been on for daily and debug builds already, however, you can test it by creating a new account either through entering your email or scanning a QR code from desktop. We do not turn on push by default for users importing their settings via another app or file.

This turns IMAP IDLE on by default. That doesn't necessarily mean you'll get push notifications by default, only that changes on the email server are immediately updated locally. If the user has notifications turned off, this will just improve the app's syncing. Otherwise, they'll also receive notifications as new emails come in.

AI Disclosure

Select one of the following (mandatory)

• This contribution does not include any changes created or assisted by AI.
• This contribution includes changes assisted by AI.
• This contribution includes changes created by AI.

Contribution Checklist

• I have read, and I affirm that my contribution adheres to Mozilla’s Community Participation Guidelines
• This contribution is in Kotlin where possible
• This contribution does not use merge commits
• This contribution adheres to the existing codestyle (run gradlew spotlessCheck to check and gradlew spotlessApply to format your source code; will be checked by CI).
• This contribution does not break existing unit tests (run gradlew testDebugUnitTest; will be checked by CI).
• This contribution includes tests for any new functionality and maintains tests for any updated functionality.
• This contribution adheres to our Engineering process (RFC/Technical Design/ADR)
• This PR has a descriptive title and body that accurately outlines all changes made and contains a reference to any issues that it fixes (e.g. Closes #XXX or Fixes #XXX).

[dougsparling]

Surprised this wasn't the default already, LGTM!

[dougsparling]

Just curious, would it also be possible for us to do this via the feature flag server? Or is the intent for this only to be the default for this version onwards? And if the change looks good, is the idea that we'd go back and delete the false (i.e. now unused) branches for this flag?

[dani-zilla]

We would eventually use remote feature flags for this kind of thing. However, the default for this will be on. We do have to do some cleanup, removing the default-on feature flags, but it's being kept here for now just to make sure there aren't issues so we can more quickly revert if changes are needed.