Repository navigation
fix: deliver actionable deployment failures and reduce repeated warnings - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary authenticated upload/link failures could lose their response when the server immediately destroyed the stream, leaving CI with only a connection reset. This delivers written failure records before closing and reports the stable reason and request phase in CLI output and JSON.
SERVER_ERROR; preserve explicit storage-guard codes. Logs add a fixed phase and allowlisted errno without paths, messages, stacks or hook secrets.Validation: complete Node 22/24 and Bare suites passed with 622 tests each before the wording correction; all 134 affected Node 22 tests passed after correction. Final lint/public types and package checks passed. A real local DHT fixture using the published 0.3.0 client verified file/directory uploads, unchanged retries and fail-closed handling of the new code. Independent review found three wording issues; all were corrected and re-reviewed clean.
Both client and server should move to 0.6.3 for the improved diagnostics. This changes no upload limits, reservation accounting, protocol fields, authentication, hooks or retention policy, and does not solve a real lack of disk space. Older clients still upload successfully but reject the new
SERVER_ERRORcode as an invalid record.