Repository navigation
Adding support for XS groups with numerical labels - #2730
Merged
Merged
Conversation
john-science
marked this pull request as ready for review
November 4, 2026 23:42
yardasol
reviewed
Nov 10, 2026
yardasol
left a comment
yardasol
left a comment
Collaborator
There was a problem hiding this comment.
Just a couple comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change? Why is it being made?
It appears that XS group labels that include digits (0-9) is almost supported, but not quite. This PR fills that gap, at least in the only location we have so far found to be lacking.
The logic in this method is now quite a bit more complicated. But I beefed up the testing to prove that it's working correctly.
Interestingly, I found we had a unit test that should have been throwing an error before, because
getXSTypeLabelFromNumber(130)was being called, and that should have thrown an error, but it didn't.close #2717
SCR Information
Change Type: features
One-Sentence Rationale: 26 XS groups is not enough, and there was a call to support more.
One-line Impact on Requirements: NA
Checklist
docfolder.pyproject.toml.