Repository navigation
Conversation
…scss uses @angular/material since tensorflow#7165. Declare it directly instead of relying on the transitive dep through theme, which the internal build's strict Sass deps check rejects.
cdavalos7
marked this pull request as ready for review
October 23, 2026 22:06
arcra
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Since #7165,
header_component.scssuses@angular/materialdirectly, butheader_stylesonly declares//tensorboard/webapp/themeand gets the Material Sass sources transitively. The OSS build allows this. The internal build requires direct Sass deps and rejects it.Technical description of changes
//tensorboard/webapp/angular_components:material_sassto theheader_stylesdeps intensorboard/webapp/header/BUILD, matching the other Sass targets that use Material.