Repository navigation
Block API-key credentials and mislead-free model UI in shared deployment - #4
Merged
Merged
Conversation
/api/credentials had no shared-deployment guard: any STFC-internal visitor to the now-public agent-gpu instance could POST a new provider key and silently override it for every subsequent user (or read configured-provider presence). Reject both routes like projects/conversations already do (design doc §19.2 precedent). Frontend: Settings' API-key rows now show disabled with an explanatory message instead of a live, silently-rejected Save button; the model picker defaults to and can only select the local Qwen model in shared deployment, since resolve_model()'s env override serves it regardless of what's picked -- a selectable-looking Claude/OpenAI/Gemini option would misrepresent which model actually answers.
junwen94
added a commit
that referenced
this pull request
Sep 29, 2026
Resolves the selectedModel init conflict: shared deployment still locks to the local Qwen model (stfc/main's fix), non-shared restores whatever model was last picked instead of resetting to Claude (#4, this branch's own fix) -- both apply, gated on SHARED_DEPLOYMENT.
4 tasks
junwen94
added a commit
that referenced
this pull request
Oct 9, 2026
…mmits The "#3/#4/#5/#6/#7/#9" comments and README's "see issue #1" referred to junwen94/goldilocks-agent, which was deleted. On this repository the same numbers are unrelated PRs (#1 is the Ollama-backend PR). The comments now name the commits that fixed those bugs (cc5f0dc, c7bfc57), whose messages name the original issues. Refs #12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/api/credentials had no shared-deployment guard: any STFC-internal visitor to the now-public agent-gpu instance could POST a new provider key and silently override it for every subsequent user (or read configured-provider presence). Reject both routes like projects/conversations already do (design doc §19.2 precedent).
Frontend: Settings' API-key rows now show disabled with an explanatory message instead of a live, silently-rejected Save button; the model picker defaults to and can only select the local Qwen model in shared deployment, since resolve_model()'s env override serves it regardless of what's picked -- a selectable-looking Claude/OpenAI/Gemini option would misrepresent which model actually answers.