Skip to content

fix: async LSP bails on no result #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liskin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: async LSP bails on no result #873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lua/conform/lsp_format.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ function M.format(options, callback)
end
request(client, method, params, function(err, result, ctx, _)
vim.api.nvim_del_autocmd(auto_id)
if not result then
return callback(err or "No result returned from LSP formatter")
if err then
return callback(err)
elseif not vim.api.nvim_buf_is_valid(bufnr) then
return callback("buffer was deleted")
elseif changedtick ~= require("conform.util").buf_get_changedtick(bufnr) then
Expand All @@ -136,6 +136,8 @@ function M.format(options, callback)
vim.api.nvim_buf_get_name(bufnr)
)
)
elseif not result then
do_format(next(clients, idx))
else
local this_did_edit = apply_text_edits(
result,
Expand Down
Loading