Repository navigation
docs: updates for published source releases (4) - #1917
solana-docs-checker[bot] wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
[Low impact] The PR appears safe to merge, with two non-blocking documentation findings still open. FindingsSummaryUpdates seven documentation pages for published Solana releases.
Reviews (100) · Last reviewed commit: "docs(anza-xyz/solana-sdk@reward-info@v7...." · Reviewed by Greptile |
d54d1c8 to
73d24cc
Compare
73d24cc to
309f486
Compare
309f486 to
e71e165
Compare
b9eca94 to
143fc58
Compare
|
@catmcgee, new published release findings were added:
|
|
Thanks for the contribution. Before this can proceed through review, please squash this PR to one commit and amend/sign that final commit so GitHub shows it as Verified. The current head has 3 commit(s), and GitHub reports Please force-push the updated branch when ready; we will re-run the review against the new head. |
| | [`UnbalancedTransaction`](https://github.com/anza-xyz/solana-sdk/blob/clock%40v2.2.3/transaction-error/src/lib.rs#L136) | Post-execution check | Total lamport balance before the transaction does not equal the balance after | | ||
| | [`ProgramCacheHitMaxLimit`](https://github.com/anza-xyz/solana-sdk/blob/clock%40v2.2.3/transaction-error/src/lib.rs#L139) | Account loading | Program cache hit max limit | | ||
| | [`CommitCancelled`](https://github.com/anza-xyz/solana-sdk/blob/clock%40v2.2.3/transaction-error/src/lib.rs#L142) | Commit | Commit cancelled internally | | ||
| | [`BailOut`](https://github.com/anza-xyz/solana-sdk/blob/master/transaction-error/src/lib.rs) | Block production | Block production bailed out; transaction is discarded to protect the leader and is explicitly excluded from consensus (does not propagate to followers) | |
There was a problem hiding this comment.
This table is presented as the complete TransactionError enum, and every existing entry points to the immutable clock@v2.2.3 definition. The new BailOut entry is absent from that release and instead links to mutable master, so readers cannot verify the documented variant or behavior against the table's stated SDK version. Please link it to the specific release that introduced it or update the table's documented version.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
@catmcgee, new published release findings were added:
|
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
@catmcgee, new published release findings were added:
|
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
| `map` over them. Note that the `'json'` overload's `transaction` is typed as | ||
| `never`: the JSON path decompiles the message server-side, so there are no | ||
| re-encodable wire bytes to return. |
There was a problem hiding this comment.
JSON encoding explained incorrectly
The new callout says json decompiles the message on the server, but json returns compiled instructions with account indexes. Server-side parsing belongs to jsonParsed, which this page correctly says the decoder rejects. This blurs the difference between the encodings and makes it harder for readers to choose one.
Remove the server-side claim and explain only that the json response does not include serialized transaction bytes.
| `map` over them. Note that the `'json'` overload's `transaction` is typed as | |
| `never`: the JSON path decompiles the message server-side, so there are no | |
| re-encodable wire bytes to return. | |
| `map` over them. Note that the `'json'` overload's `transaction` is typed as | |
| `never`: the JSON response contains compiled instructions rather than | |
| serialized transaction bytes. |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
ababove20-jpg
left a comment
There was a problem hiding this comment.
This section clearly outlines the necessary checks for program accounts, ensuring that only valid loaders are used and that transactions fail gracefully when accounts are missing or misconfigured. It helps maintain the integrity and security of program execution on Solana.
Documentation updates for published source releases
@catmcgee, this rolling PR contains documentation changes for newly published releases.
Each commit corresponds to one published release. Squash-merge or cherry-pick as appropriate.
Last checked: 2026-11-21T09:09:02.545Z UTC
Releases covered: 4
Files updated: 7
Findings needing manual review: 1
Releases covered by this branch
anza-xyz/kit@v7.1.0 — v7.1.0
Files updated:
apps/docs/content/docs/en/core/transactions/transaction-introspection.mdxanza-xyz/kit-plugins@@solana/kit-plugin-rpc@0.16.0 — @solana/kit-plugin-rpc@0.16.0
Files updated:
apps/docs/content/docs/en/frontend/client.mdxanza-xyz/solana-sdk@offchain-message@v3.0.1 — offchain-message@v3.0.1
Files updated:
apps/docs/content/docs/en/core/transactions/transaction-pipeline.mdxanza-xyz/solana-sdk@reward-info@v7.0.0 — reward-info@v7.0.0
Files updated:
apps/docs/content/docs/en/core/accounts/account-runtime.mdxapps/docs/content/docs/en/rpc/http/getblock.mdxapps/docs/content/docs/en/rpc/json-structures.mdxapps/docs/content/docs/en/core/accounts/account-types.mdxFindings that need manual review
These findings could not be applied cleanly. Review them manually.
solana-foundation/solana-web3.js@v1.99.0 — @solana/web3.js v1.99.0
apps/docs/content/docs/en/payments/agentic-payments/intro-to-x402.mdx(high, original-file-not-found) — The inline comment in the USDC server example states thatweb3.js v1 cannot deserialize v1 transactionsand instructs readers to use@solana/kitorweb3.js v3withmaxSupportedTransactionVersion: 1. With the v1.99.0 release,@solana/web3.js(v1) now supports reading v1 transactions via the newMessageV1class andVersionedTransaction.deserializebranch (TransactionVersion = 'legacy' | 0 | 1), so this claim is no longer true and the cappedmaxSupportedTransactionVersion: 0is misleading for a v1-payment facilitator built on web3.js v1.Suggested edits
find:
replace: