Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--themeacceptsdefaultas a special value, but it is missing from the "Special values" list in the man page.src/theme.rs:138-145—ThemeName::newmaps the literal string"default"toThemeName::Default, so--theme=default/BAT_THEME=defaultis not a theme name lookup.src/theme.rs:30-35—default_theme(ColorScheme::Dark)is"Monokai Extended".src/theme.rs:420-433— the testdefault_dark_if_requested_explicitly_through_themeasserts that an explicitly requestedThemeName::Defaultresolves to the dark default theme for every detected color scheme, i.e. it does not adapt to the terminal.README.md:738showsbat --theme=default "$@".The entry is added after
light, matching the surrounding.IPstyle. Along the way this fixes a duplicated "where" on theauto:alwaysentry (assets/manual/bat.1.in:187).No changelog entry:
CONTRIBUTING.mdstates one is not necessary for documentation updates, and the note there says the verifying workflow failure can be disregarded in that case.Only
assets/manual/bat.1.inis touched. The renderedbat.1is gitignored (.gitignore:14) and produced at build time from this template bybuild/application.rs:42-43, anddoc/long-help.txtis the--helpsnapshot checked bytests/integration_tests.rs:868— both are generated from other sources, and the same special-values list inclap_app.rs:429-441also omitsdefault. I left the--helptext alone to keep this to one file; say the word if you would rather it be extended there as well.Checklist
.IP/ prose form of its neighbours.CONTRIBUTING.md.clap_app.rstoken was touched, socargo testcannot be affected. I could not runcargoin my sandbox (the command was blocked by the environment), so this rests on the diff being template text only.Overlap: the open PRs editing nearby man-page text are #4012 (
-b, --number-nonblank), #4086 (nonblank numbering), #4009 (BAT_WIDTH), #4078/#4077 (--fallback-syntax,--sanitize) and #4033 (grammar in the--style/--pagingpassages, plusclap_app.rs); none of them modify lines 181-194.AI assistance disclosure: an AI tool was used to diff the man page against
src/theme.rsand to locate theREADME.md:738usage; I reviewed the enum, the constant and the test myself and can answer questions about the roff and theme semantics.