Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the iOS CI additions alongside the existing macOS checks.
No open issues 🎉
What changed in this PR
Extends the Swift CI workflow to build and test SFBAudioEngine on iOS alongside the existing macOS checks.
Changes:
- Renames existing build and test steps to identify them as macOS checks.
- Adds an unsigned build for generic iOS devices.
- Adds a build and test step targeting the iPhone 17 Pro simulator with code signing disabled.
| File | Description |
|---|---|
.github/workflows/swift.yml |
Adds iOS device and simulator checks while retaining macOS build and test steps. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.