Repository navigation
test: pin published MCP tool names and arguments - #51
Merged
Merged
Conversation
Agents call read_url/read_batch/list_inbox/detect_platform by name and argument shape. A rename, new required argument or type change now fails CI instead of silently breaking existing clients (see #26). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agents call
read_url,read_batch,list_inboxanddetect_platformby name and argument shape. Nothing pinned that contract, so a rename, a new required argument or a type change could ship silently and break existing MCP clients (the concern raised in #26).This adds
McpToolSchemaContractTesttotests/test_mcp_dependency_contract.py, which reads the schema FastMCP publishes viatools/listand asserts:Changing the public tool surface now requires a deliberate edit to
PUBLISHED_TOOL_ARGUMENTS.Test plan
python -m unittest discover -s tests -p "test_*.py"in a fresh venv withpip install -e ".[mcp]"(as CI does): 372 tests OK (was 370)read_urlmakestest_published_tool_arguments_stay_stablefail; reverted🤖 Generated with Claude Code