Skip to content

Add <numeric> for std::accumulate - #157

Merged
christophebedard merged 1 commit into
ros-tooling:rollingfrom
christophfroehlich:fix-includes
Nov 14, 2026
Merged

christophebedard merged 1 commit into
ros-tooling:rollingfrom
christophfroehlich:fix-includes

Conversation

@christophfroehlich

Copy link
Copy Markdown
Contributor

Description

Found while debugging ros-controls/topic_based_hardware_interfaces#150

https://en.cppreference.com/cpp/algorithm/accumulate

Is this user-facing behavior change?

no

Did you use Generative AI?

no

Additional Information

none

Signed-off-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
@christophfroehlich

Copy link
Copy Markdown
Contributor Author

I fixed the DCO.
@emersonknapp @MichaelOrlov please consider this and a new release to fix it on the buildfarm https://build.ros2.org/job/Rbin_uR64__topic_tools__ubuntu_resolute_amd64__binary/47/

@christophfroehlich

Copy link
Copy Markdown
Contributor Author

@christophebedard maybe?

@christophebedard

Copy link
Copy Markdown
Member

@ros-pull-request-builder retest this please

@christophebedard

Copy link
Copy Markdown
Member

@ros-pull-request-builder retest this please

@christophebedard

Copy link
Copy Markdown
Member

Would've been nice to have the Rpr job here, but I guess it was never set up for this repo. I set up *pr job hooks and enabled test_pull_requests (e.g., Rolling in ros/rosdistro#55424). Just waiting on whoever has access to @ros-pull-request-builder to accept the invitation for access to this repo.

@christophebedard christophebedard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix! I'll create a new release

@christophebedard
christophebedard merged commit d6074b1 into ros-tooling:rolling Nov 14, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants