Repository navigation
[RF] Remove flattening of nested RooSimultaneous in the constructor - #23669
Open
guitargeek wants to merge 1 commit into
Open
guitargeek wants to merge 1 commit into
guitargeek wants to merge 1 commit into
Conversation
Test Results 23 files 23 suites 3d 18h 53m 53s ⏱️ Results for commit 39ab298. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
rf-sim-nested-replication-644
branch
from
October 29, 2026 15:31
50c6ff3 to
31c019c
Compare
The flattening of RooSimultaneous components into a one-level RooSimultaneous over a RooSuperCategory was deprecated in ROOT 6.42 and is now removed. RooSimultaneous components are kept as they are, which also allows adding them with `addPdf()`. Nested RooSimultaneous in "switch mode", whose index category is a parameter, now work. To support them also for toy generation and for plotting slices of the outer RooSimultaneous, the generator contexts and `RooSimultaneous::plotOn()` use the selected component of a nested RooSimultaneous whose index category is not generated or projected. If the index category of a nested RooSimultaneous is in the dataset, creating the likelihood fails with a clear error for all evaluation backends. The check covers RooSimultaneous nested at any depth, also below a RooSimultaneous in switch mode. RooSimultaneous objects that were flattened by previous ROOT versions and are read from files are not affected. The internal `RooSimultaneous::InitializationOutput` struct and `RooSimultaneous::initialize()` function are removed. 🤖 Done with the help of AI
guitargeek
force-pushed
the
rf-sim-nested-replication-644
branch
from
October 30, 2026 19:10
31c019c to
39ab298
Compare
guitargeek
marked this pull request as ready for review
October 30, 2026 19:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flattening of RooSimultaneous components into a one-level RooSimultaneous over a RooSuperCategory was deprecated in ROOT 6.42 and is now removed. RooSimultaneous components are kept as they are, which also allows adding them with
addPdf().Nested RooSimultaneous in "switch mode", whose index category is a parameter, now work. To support them also for toy generation and for plotting slices of the outer RooSimultaneous, the generator contexts and
RooSimultaneous::plotOn()use the selected component of a nested RooSimultaneous whose index category is not generated or projected.If the index category of a nested RooSimultaneous is in the dataset, creating the likelihood fails with a clear error for all evaluation backends. The check covers RooSimultaneous nested at any depth, also below a RooSimultaneous in switch mode.
RooSimultaneous objects that were flattened by previous ROOT versions and are read from files are not affected.
The internal
RooSimultaneous::InitializationOutputstruct andRooSimultaneous::initialize()function are removed.🤖 Done with the help of AI