Repository navigation
testscript: remove the work directory root with all its contents - #312
Merged
Merged
Conversation
testscript removes each script's work directory with all its contents, but the directory holding them only with os.Remove, which fails if it is not empty. A Setup function which creates files next to the work directories, such as a shared configuration file, therefore leaves a go-test-script directory behind in the system temporary directory.
Use removeAll rather than os.Remove, so that files created by Setup functions next to the work directories do not keep it around. The directory is created by testscript itself and is only removed when work directories are not kept, so its contents are never wanted afterwards.
myitcv
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(see commit messages - please do not squash)
This resolves a case where testscripts in the CUE repo were leaking temporary directories.