Repository navigation
testscript: add dynamic command capability - #306
Merged
Merged
Conversation
mvdan
approved these changes
Jun 10, 2026
| "register": func(ts *TestScript, neg bool, args []string) { | ||
| // register <name> <text> dynamically defines a command | ||
| // that writes <text> to stdout, for the rest of the test. | ||
| if len(args) != 2 { |
Collaborator
There was a problem hiding this comment.
also fail if negated? ! register ... doesn't seem to make sense
Owner
Author
There was a problem hiding this comment.
This is only for tests; I don't think it matters that much tbh.
Owner
Author
There was a problem hiding this comment.
(note: we already ignore neg for all the other commands in this set - I don't think this is any different)
|
|
||
| register greet 'hi again' | ||
| greet | ||
| stdout '^hi again$' |
Collaborator
There was a problem hiding this comment.
nit: perhaps verify that if you do register most_definitely_not_in_path 'whatever', then exec most_definitely_not_in_path fails
rogpeppe
force-pushed
the
053-dynamic-commands
branch
from
June 10, 2026 09:18
09f3842 to
d721b23
Compare
This allows a command to be able to add more commands, which is useful for the up-coming plugin functionality.
rogpeppe
force-pushed
the
053-dynamic-commands
branch
from
June 10, 2026 09:21
d721b23 to
c1eb882
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a command to be able to add more commands, which is useful for the up-coming plugin functionality.