Skip to content

Drop actix-web compression features - #228

Merged
darkmuggle merged 1 commit into
mainfrom
bh/actix-no-compress
Oct 28, 2026
Merged

darkmuggle merged 1 commit into
mainfrom
bh/actix-no-compress

Conversation

@darkmuggle

@darkmuggle darkmuggle commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

The operator only serves GET /health and /metrics (plus /ready and / in restate-operator), and it never reads a request body. Even so, actix-web's default features link in request decompression for Brotli, gzip and zstd.

This change turns off the default features and keeps only macros. Without the decoders in the binary, it is no longer in scope for Brotli decoder advisories such as CVE-2026-111497. The operator was not reachable through that bug before this change, because no handler reads a body.

The lockfile diff only removes packages (brotli, brotli-decompressor, zstd*, cookie, h2 and their dependencies). No dependency versions change.

Checks: fmt, clippy with -D warnings, and the test suite all pass.

The operator serves GET /health and /metrics only, so it never needs
request decompression. Without the default compress-* features the
Brotli, zstd and gzip decoders are no longer linked in, which takes the
binary out of scope for Brotli decoder advisories such as
CVE-2026-111497.
@darkmuggle
darkmuggle merged commit 54d52ac into main Oct 28, 2026
8 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 28, 2026
@darkmuggle
darkmuggle deleted the bh/actix-no-compress branch October 28, 2026 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant