Skip to content

Feature/genericl2doc - #267

Open
nhanasi wants to merge 13 commits into
developfrom
feature/genericl2doc
Open

nhanasi wants to merge 13 commits into
developfrom
feature/genericl2doc

Conversation

@nhanasi

@nhanasi nhanasi commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Hanasi and others added 10 commits November 3, 2026 15:12
* Use L2 Script from Docker repo

* test branch

* ci: regenerate L2_Coverage.md [skip ci]

* Update the additional details file l2_coverage_details.json

* ci: regenerate L2_Coverage.md [skip ci]

* Update L2-tests.yml

* ci: regenerate L2_Coverage.md [skip ci]

---------

Co-authored-by: Hanasi <nhanas001c@cable.comcast.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@nhanasi
nhanasi requested a review from a team as a code owner November 4, 2026 19:17
Copilot AI balanced review requested due to automatic review settings November 4, 2026 19:17
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Summary

                               Total:|84.0%   6280|97.3%  1668|    -      0

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the L2 workflow’s switch to the test repository’s feature/l2docupdate branch.

No open issues 🎉

What changed in this PR

This PR changes which branch of the external test repository is used by the remote debugger’s L2 test workflow.

Changes:

  • Switches the rdkcentral/docker-device-mgt-service-test checkout from develop to feature/l2docupdate.
File Description
.github/​workflows/​L2-tests.yml Points the test repository checkout to feature/l2docupdate.

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 4, 2026 19:18
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Summary

                               Total:|84.0%   6280|97.3%  1668|    -      0

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new fail-fast invocation aborts on clean checkouts because the shared runner calls automake before autoreconf generates aclocal.m4, preventing both builds from reaching tests.

1 open issue

Review effort: Balanced

- name: Run unit tests
run: sh run_ut.sh
run: |
if sh -e run_ut.sh --enable-cov; then
Copilot AI balanced review requested due to automatic review settings November 4, 2026 19:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Fail-fast execution stops both PR and baseline jobs because Automake runs before Autotools bootstrapping on fresh checkouts, preventing tests and coverage collection.

1 open issue
2 previously missed issues

In code that hasn't changed since last review

High severity Bootstrap Autotools in the base checkout

.github/​workflows/​L1-Test.yml:47

The fresh base checkout lacks generated Autotools files, but run_ut.sh invokes Automake before Autoreconf. With sh -e, the initial Automake failure stops baseline coverage collection; bootstrapping the PR checkout does not initialize this separate tree. Run autoreconf --install in the base checkout's src/unittest before invoking the runner.

Medium severity Exclude test and mock code from coverage totals

.github/​workflows/​L1-Test.yml:81

These totals include the test runner and mocks: run_ut.sh filters out only /usr/*, while src/unittest/Makefile.am instruments the entire runner. Adding covered test lines can therefore make this check pass even when production line coverage decreases. Exclude unit-test and mock sources from both totals before comparing coverage.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants