You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The new fail-fast invocation aborts on clean checkouts because the shared runner calls automake before autoreconf generates aclocal.m4, preventing both builds from reaching tests.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Fail-fast execution stops both PR and baseline jobs because Automake runs before Autotools bootstrapping on fresh checkouts, preventing tests and coverage collection.
The fresh base checkout lacks generated Autotools files, but run_ut.sh invokes Automake before Autoreconf. With sh -e, the initial Automake failure stops baseline coverage collection; bootstrapping the PR checkout does not initialize this separate tree. Run autoreconf --install in the base checkout's src/unittest before invoking the runner.
Exclude test and mock code from coverage totals
.github/workflows/L1-Test.yml:81
These totals include the test runner and mocks: run_ut.sh filters out only /usr/*, while src/unittest/Makefile.am instruments the entire runner. Adding covered test lines can therefore make this check pass even when production line coverage decreases. Exclude unit-test and mock sources from both totals before comparing coverage.
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.