[Kaavyashree2]

• Sanitized IssueType inputs in shell commands
• Improved validation of MsgPack object types returned by finder()
• Integer overflow prevention

[github-actions]

Code Coverage Summary

                               Total:|84.0%   6280|97.3%  1668|    -      0

[Copilot]

🟢 Approval recommended

There are no active review issues for the change that sanitizes issue types used in log archive filenames.

No open issues 🎉

What changed in this PR

This PR hardens issue-type handling in the remote-debugger log upload script before the value is included in archive filenames.

Changes:

• Replaces unquoted echo with quoted printf to avoid word splitting and wildcard expansion.
• Converts the issue type to uppercase and restricts it to A-Z, digits, underscores, and hyphens.

File	Description
scripts/​uploadRRDLogs.sh	Sanitizes the issue type used in log archive filenames.

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The new null assertion always fails because the unchanged decoder returns the matching string value despite the requested integer type, without setting errno.

1 open issue

• Fix decoder type validation and metadata lookup types · New

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The decoder contains invalid syntax that blocks compilation, an unchecked metadata pointer that can cause a null dereference, and an unhandled overflow result that can lead to a heap buffer overflow.

4 open issues

• Fix malformed if-condition parentheses · New
• Validate metadata pointers before dereferencing · New
• Reject overflow before allocating or copying · New
• Fix decoder type validation and metadata lookup types

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

The decoder contains a syntax error that prevents compilation and unchecked metadata pointers that can cause malformed input to crash the daemon.

4 open issues

• Reject overflow before allocating or copying
• Validate metadata pointers before dereferencing
• Fix malformed if-condition parentheses
• Fix decoder type validation and metadata lookup types

_{Review effort: Balanced}

[github-actions]

Code Coverage Summary

                               Total:|83.9%   6285|97.3%  1668|    -      0

[Copilot]

🟡 Changes recommended

Unresolved critical issues allow malformed metadata to crash the daemon and unchecked command lengths to overflow downstream storage or allocations, risking out-of-bounds writes.

5 open issues

• Reserve space for the caller's extra byte in size checks · New
• Reject lengths that exceed the downstream int limit · New
• Reject overflow before allocating or copying
• Validate metadata pointers before dereferencing
• Fix decoder type validation and metadata lookup types

1 resolved since last review

• Fix malformed if-condition parentheses

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Malformed metadata can cause null-pointer dereferences that crash the daemon, and the new overflow test fails on 64-bit hosts because its string length is truncated.

1 open issue

• Use a representable MsgPack string size in the overflow test · New

5 resolved since last review

• Reject lengths that exceed the downstream int limit
• Reserve space for the caller's extra byte in size checks
• Reject overflow before allocating or copying
• Validate metadata pointers before dereferencing
• Fix decoder type validation and metadata lookup types

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Malformed metadata can trigger a NULL-pointer dereference that crashes the daemon, and the new overflow test fails on 64-bit hosts due to truncation of the uint32_t string length.

1 open issue

• Use a representable MsgPack string size in the overflow test

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Malformed metadata can trigger a NULL dereference that crashes the daemon, and the new overflow test incorrectly expects zero on 64-bit platforms.

1 open issue

• Use a representable MsgPack string size in the overflow test

_{Review effort: Balanced}

[github-actions]

Code Coverage Summary

                               Total:|83.9%   6293|97.3%  1668|    -      0

[Copilot]

🟡 Changes recommended

Malformed metadata can trigger NULL dereferences that crash the daemon, and the length checks still allow allocation-size overflow on 32-bit targets.

1 open issue

• Enable overflow tests with lengths valid on both architectures · New

1 resolved since last review

• Use a representable MsgPack string size in the overflow test

_{Review effort: Balanced}