[Kaavyashree2]

No description provided.

[github-actions]

Code Coverage Summary

                               Total:|84.0%   6280|97.3%  1668|    -      0

[Copilot]

🟢 Approval recommended

No active review issues were identified for the change that sanitizes issue types used in log archive filenames.

No open issues 🎉

What changed in this PR

This PR hardens issue-type handling in the RRD log-upload script by normalizing and filtering the value used in archive filenames.

Changes:

• Replaces unquoted echo with quoted printf to preserve the input during processing.
• Converts the issue type to uppercase and restricts it to letters, digits, underscores, and hyphens.

File	Description
scripts/​uploadRRDLogs.sh	Sanitizes the issue type used to name uploaded log archives.

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

There are no active review issues for the filename-sanitization and coverage-report changes.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Critical validation gaps still accept malformed debugger data and abbreviated metadata keys, while allocation-size overflow can cause out-of-bounds writes.

5 open issues

• Require exact metadata key lengths · New
• Reject present but invalid optional wrappers · New
• Prevent SIZE_MAX result-length allocation overflow · New
• Update test for strict string type matching · New
• Add required metadata to the success-test fixture · New

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Unresolved validation gaps accept malformed wrappers and abbreviated metadata keys, while mandatory metadata checks break an existing success test and new overflow tests contain incorrect size assumptions and out-of-bounds reads.

7 open issues

• Use representable lengths in the size_t overflow test · New
• Prevent SIZE_MAX result-length allocation overflow
• Reject present but invalid optional wrappers
• Require exact metadata key lengths
• Initialize both objects used by the array-boundary test · New
• Add required metadata to the success-test fixture
• Update test for strict string type matching

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Metadata validation accepts prefix keys and breaks existing success fixtures, while new overflow tests fail on 64-bit hosts and trigger an out-of-bounds read.

7 open issues

• Use representable lengths in the size_t overflow test
• Prevent SIZE_MAX result-length allocation overflow
• Reject present but invalid optional wrappers
• Require exact metadata key lengths
• Initialize both objects used by the array-boundary test
• Add required metadata to the success-test fixture
• Update test for strict string type matching

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Unresolved decoder validation flaws accept abbreviated required-field keys and wrongly typed wrappers, while the new metadata requirement breaks an existing success test.

5 open issues

• Prevent SIZE_MAX result-length allocation overflow
• Reject present but invalid optional wrappers
• Require exact metadata key lengths
• Add required metadata to the success-test fixture
• Update test for strict string type matching

2 resolved since last review

• Use representable lengths in the size_t overflow test
• Initialize both objects used by the array-boundary test

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Metadata lookups accept partial or empty keys, and a wrongly typed remotedebugger wrapper is treated as absent, allowing invalid documents to pass validation with incorrect or zero IDs.

5 open issues

• Prevent SIZE_MAX result-length allocation overflow
• Reject present but invalid optional wrappers
• Require exact metadata key lengths
• Add required metadata to the success-test fixture
• Update test for strict string type matching

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Critical metadata-validation and size-check defects can cause NULL dereferences and allocation overflow leading to out-of-bounds writes.

4 open issues

• Reject missing or mistyped metadata before processing
• Reject present but invalid optional wrappers
• Require exact metadata key lengths
• Update test for strict string type matching

1 resolved since last review

• Fix malformed condition syntax

_{Review effort: Balanced}

[github-actions]

Code Coverage Summary

                               Total:|83.9%   6285|97.3%  1668|    -      0

[Copilot]

🔵 Needs a closer look

Metadata key matching accepts prefixes and empty keys, allowing malformed entries to populate version or transaction ID fields; exact key-length checks are needed.

3 open issues

• Reject missing or mistyped metadata before processing
• Require exact metadata key lengths
• Update test for strict string type matching

1 resolved since last review

• Reject present but invalid optional wrappers

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

The decoder still permits allocation-size overflow and length narrowing, while prefix-based metadata matching can accept incorrect keys or shadow valid fields.

3 open issues

• Reject missing or mistyped metadata before processing
• Require exact metadata key lengths
• Update test for strict string type matching

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The strict key-length check rejects the success-test fixture’s incorrectly packed remotedebugger key, returning an empty document and failing assertions until both fixture packing lengths are corrected.

2 open issues

• Reject missing or mistyped metadata before processing
• Fix fixture length for remotedebugger optional wrapper · New

2 resolved since last review

• Require exact metadata key lengths
• Update test for strict string type matching

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

The length guard fails to reserve the extra allocation byte, allowing the allocation size to wrap to zero on 32-bit targets and potentially permitting out-of-bounds writes.

2 open issues

• Reject missing or mistyped metadata before processing
• Fix fixture length for remotedebugger optional wrapper

_{Review effort: Balanced}

[github-actions]

Code Coverage Summary

                               Total:|83.9%   6286|97.3%  1668|    -      0

[Copilot]

🔵 Needs a closer look

Malformed metadata can trigger NULL-pointer dereferences that crash the daemon, and the stricter key-length check breaks the existing conversion-success fixture.

1 open issue

• Reject missing or mistyped metadata before processing

1 resolved since last review

• Fix fixture length for remotedebugger optional wrapper

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Malformed metadata can crash the daemon through unchecked NULL pointers, and incomplete size checks can allow allocation-size overflow and out-of-bounds writes.

1 open issue

• Reject missing or mistyped metadata before processing

_{Review effort: Balanced}