Skip to content

L2 Coverage Generation Using Docker Script - #260

Merged
nhanasi merged 8 commits into
developfrom
feature/genericl2doc
Nov 4, 2026
Merged

nhanasi merged 8 commits into
developfrom
feature/genericl2doc

Conversation

@nhanasi

@nhanasi nhanasi commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI balanced review requested due to automatic review settings November 3, 2026 20:16
@nhanasi
nhanasi requested a review from a team as a code owner November 3, 2026 20:16
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Summary

                               Total:|84.0%   6280|97.3%  1668|    -      0

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The local instructions omit the required shared-repository ref, so running the documented command from a normal clone fails because the report script is absent from the default branch.

1 open issue
What changed in this PR

This PR moves Remote Debugger’s L2 coverage reporting to shared tooling, removing the component-specific generator and updating the workflow and documentation.

Changes:

  • Check out the shared tooling and invoke its generator with --component "Remote Debugger".
  • Remove the local coverage-report script.
  • Document local usage and distinguish measured coverage from manual behavior assessments.
File Description
test/​functional-tests/​generate_l2_coverage_report.py Removes the component-specific report generator.
docs/​rrd_l2_function_coverage_HLD.md Documents shared tooling usage and report limitations.
.github/​workflows/​L2-tests.yml Checks out and invokes the shared generator.

Review effort: Balanced

Comment thread docs/rrd_l2_function_coverage_HLD.md Resolved
Copilot AI balanced review requested due to automatic review settings November 3, 2026 20:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The local setup instructions omit the required shared-tooling revision, so a default-branch checkout lacks the generator and the documented command fails.

1 open issue

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 3, 2026 20:57
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Summary

                               Total:|84.0%   6280|97.3%  1668|    -      0

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The checked-in coverage report contains only four of the configured generator’s eight sections, omitting module guidance and contradicting the updated HLD.

1 open issue
1 resolved since last review

Review effort: Balanced

Comment thread test/functional-tests/L2_Coverage.md Resolved
Copilot AI balanced review requested due to automatic review settings November 3, 2026 21:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the move to shared L2 coverage reporting.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 4, 2026 15:11
@nhanasi nhanasi changed the title Feature/genericl2doc L2 Coverage Generation Using Docker Script Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Summary

                               Total:|84.0%   6280|97.3%  1668|    -      0

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The local reproduction instructions specify feature/l2docupdate instead of the workflow’s develop ref, leaving the documented procedure inconsistent with CI.

1 open issue

Review effort: Balanced

- Markdown report with summary metrics, tables, and scenario coverage status

For local use, check out both repositories into the same parent directory, using
`feature/l2docupdate` for `docker-device-mgt-service-test` to match the PR workflow.
Copilot AI balanced review requested due to automatic review settings November 4, 2026 15:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The local checkout instructions use feature/l2docupdate instead of CI’s develop branch, so they must be corrected to make report generation consistent with the workflow.

1 open issue

Review effort: Balanced

@nhanasi
nhanasi merged commit 36c9f91 into develop Nov 4, 2026
8 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants